[tor-bugs] #29187 [Applications/Tor Browser]: Bump NSIS version to 3.04

[Tor Bug Tracker & Wiki]

#29187: Bump NSIS version to 3.04
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  GeorgKoppen201901, tbb-rbm,          |  Actual Points:
  TorBrowserTeam201909R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:11 boklm]:
 > Replying to [comment:1 gk]:
 > > `bug_29187` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_29187&id=8c79a97d86183c3d69f97a72338e5b515c1649d4)
 in my public repo has the fix. However, we should figure out what is going
 on in #29185 first in order to be sure 3.04 is not introducing new
 reproducibility issues.
 >
 > I started two builds on two machines with this patch on top of master,
 to check if the build is still reproducible with this version of NSIS.

 In a first test I had matching i686 builds, but non matching x86_64, but
 it was probably caused by using different commits as the builds were not
 started exactly at the same time. On a second test, I now have x86_64
 matching builds too. So this looks good to me.

 I cherry-picked the patch as commit
 936f5d7ad170e4d0dddc141906f006a6273196c8 on master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29187#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online