[tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Sep 27 14:06:57 UTC 2019
#31882: move Android build config into core tor
---------------------------------+------------------------------------
Reporter: eighthave | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: Android, tbb-mobile | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+------------------------------------
Comment (by eighthave):
Looks like the JNI wrapper can be entirely based on what's in
''tor_api.h'. You can get an idea now of what this needs, it uses only
the pieces in the current ''src/feature/api/tor_api.[ch]''. This is based
on @sysrqb's work in #26653, e.g:
https://gitweb.torproject.org/user/sysrqb/tor.git/commit/?h=testing_26653&id=731b7e2b176f7cf6439c1286886492998e58cd7f
My big question is now to add a new ''src/feature/jni'' section and still
have its symbols exported. When I add my files to ''src/feature/jni'', it
builds fine, but then its missing the exported JNI functions. The symbols
make it into the ''libtor-app.a'' but not the ''libtor.so''. My hack for
now is to just add the JNI code to ''src/feature/api/tor_api.[ch]'', that
works. The idea is to have `./configure --enable-jni`. Here's that in
progress code with the autotools changes:
https://gitlab.com/eighthave/tor/commit/a453e9faf3e4be946506111754b18f9fcf1ac595
I already have a working Android CI build in gitlab-ci (plus I started
porting the ''.travis.yml'' to ''.gitlab-ci.yml'' while I was at it and
threw in a couple of distro builds). It should be relatively
straightforward to port the Android CI job ''.travis.yml'' for someone who
know that whole matrix setup.
https://gitlab.com/eighthave/tor/blob/dbeb6f7d8/.gitlab-ci.yml
And here's an example run on the latest ''master'':
https://gitlab.com/eighthave/tor/pipelines/85003730
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31882#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list