[tor-bugs] #31334 [Core Tor/Tor]: Use SEVERITY_MASK_IDX() to find the LOG_ERR index in the unit tests

[Tor Bug Tracker & Wiki]

#31334: Use SEVERITY_MASK_IDX() to find the LOG_ERR index in the unit tests
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.5.2-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  042-can       |  Actual Points:  0.1
Parent ID:                |         Points:  0.1
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 Looks good, but should we also fix these instances?

 {{{
 % git grep 'masks' src/test
 src/test/fuzz/fuzzing_common.c:    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
 src/test/test_logging.c:  no_bug.masks[0] &= ~(LD_BUG|LD_GENERAL);
 src/test/test_options.c:  lst.masks[LOG_ERR - LOG_ERR] = ~0;
 src/test/test_options.c:  lst.masks[LOG_WARN - LOG_ERR] = ~0;
 src/test/test_options.c:  lst.masks[LOG_NOTICE - LOG_ERR] = ~0;
 src/test/testing_common.c:    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
 src/test/testing_common.c:    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31334#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online