[tor-bugs] #24920 [Applications/Tor Browser]: TBA has tabs and private tabs, we only want private tabs

[Tor Bug Tracker & Wiki]

#24920: TBA has tabs and private tabs, we only want private tabs
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201909R,   |  Actual Points:
  ux-team                                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * keywords:  tbb-mobile, TorBrowserTeam201906, ux-team => tbb-mobile,
     TorBrowserTeam201909R, ux-team
 * status:  needs_revision => needs_review


Comment:

 Okay, marking this for review - `bug24920_05`.

 I noticed in the commit-diff from the 68esr rebase
 (`1d4697df174ff83b6efa1f568b2ee154cb20b93e`) I accidentally changed the
 syntax on one of the lines.

 {{{
      if (isPrivate) {
 -      attrs.privateBrowsingId = 1;
 +      attrs['privateBrowsingId'] = 1;
      }
 }}}

 This fixup changes it back, too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24920#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online