[tor-bugs] #31607 [Applications/Tor Browser]: App menu items stop working

[Tor Bug Tracker & Wiki]

#31607: App menu items stop working
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909                           |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Kathy and I have not found a fix for this yet, and unfortunately we will
 not be able to work on this ticket again until the week of September 30th.
 We have reached out to Mozilla for help (via tjr) but it sounds like not
 many people have experience with the `widget/cocoa` code. Here is part of
 what we sent to Mozilla:
   We have determined the following:

   1) The `nsMenuBarX` destructor is being called at some point after the
 Tor Launcher window closes. This causes the application menu to stop
 working because `mMenuGroupOwner` has been cleared within the
 `MenuItemInfo` objects that are associated with the Cocoa application menu
 items.

   2) During construction of the `nsMenuBarX` object,
 `ConstructFallbackNativeMenus()` is called (it doesn't seem to be called
 if Tor Launcher is not opened at startup).

   It would be helpful if someone could give us an overview (or in-depth?)
 of how the menus / menubars are expected to work on Mac. In particular
 these are some of our questions:
   Should the `nsMenuBarX` destructor be called only before exiting the
 browser? Or is it OK that it is called while a browser window is open?

   Should `ConstructFallbackNativeMenus()` be getting called at startup?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31607#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online