[tor-bugs] #31448 [Applications/Tor Browser]: gold and lld break linking 32bit Linux bundles we need to resort to bfd

[Tor Bug Tracker & Wiki]

#31448: gold and lld break linking 32bit Linux bundles we need to resort to bfd
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-     |  Actual Points:
  alpha, TorBrowserTeam201909R                   |
Parent ID:  #30321                               |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 The patch looks good to me and it seems #31618 is fixed, too. I am still
 wondering, though, what breaks now. I tried a bunch of things:
 -different binutils versions (2.32, 2.29, 2.28.1) - no effect
 -using GCC - no effect
 -disabling hardening - no effect
 -compiling our stable branch with the toolchain on `master` - that works
 with debug symbols enabled (I had to disable Stylo, though, due to errors)

 So, it seems something between esr60 and esr68 causes the breakage. We
 should find out what it is, but we can use a new bug for that.

 I am merging the patch as it is for now: commit
 3b899b766fd13986fc3545a4294fd391b6ea139d on `master` has it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31448#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online