[tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
-------------------------------+------------------------------------
 Reporter:  asn                |          Owner:  (none)
     Type:  task               |         Status:  needs_review
 Priority:  Medium             |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID:                     |         Points:  1
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------------

Comment (by teor):

 Hi, thanks for this pull request!

 Replying to [comment:3 ltbringer]:
 > https://github.com/torproject/tor/pull/1328
 >
 > This adds `GETINFO dir/status-vote/microdesc/consensus`

 How did you come up with this GETINFO name?
 If we want the control spec to match the directory spec, it should be:
     GETINFO dir/status-vote/current/consensus-microdesc
 See https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n3895

 This ticket creates a small reduction in code quality, because it turns a
 300-line function into a 320-line function. If you would like to improve
 code quality, please add a commit that splits the two dir/status-vote/*
 GETINFOs into their own static function. Otherwise, our reviewer can do
 that for you, before they approve your pull request.

 We also need to update the control-spec, I'll open a child ticket.

 (We could do #28982 instead of this ticket, but that's a much more complex
 refactor.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31684#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online