[tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-       |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund, 042-should   |
Parent ID:  #21969                               |         Points:  0.1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:6 teor]:
 > How do we reliably detect pathological cases?
 > Suppress the message, until it occurs a few times within a short
 timeframe?

 That's a good question I don't have an answer for.

 Unfortunately, I don't think that's the kind of message that occurs
 multiple times, looking at #30746 (and friends) this seems to be able to
 cause havoc with just a single repeatition.

 I'm not sure why this is the case, since `router_have_minimum_dir_info()`
 seems to be called all the time and that should eventually call
 `entry_guards_get_err_str_if_dir_info_missing()` which is the source of
 the log message... Things are kinda messy between these two functions tho,
 so it's kinda hard to understand what's the issue.

 Perhaps we can merge this patch for now since it does not seem to make the
 situation worse, and we can think in the future how to improve the UX? If
 you agree, feel free to toggle this into merge_ready since the patch LGTM.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31657#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online