[tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  BugSmash, diagnostics, consider-     |  Actual Points:  0.9
  backport-if-needed, consider-backport-         |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe         |
Parent ID:  #31571                               |         Points:  0.3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 I also squashed the branch and did a backport to 0.4.0.
 (The backport to 0.3.5 was too complex.)

 Here is the PR to merge:
 * 0.4.0: https://github.com/torproject/tor/pull/1303

 The merge forward was clean.

 Here are the test branches for merging forwards:
 * ​​https://github.com/teor2345/tor/branches/all?query=bug31594_

 I don't think we should backport this fix, unless the bug is actually
 causing issues in older versions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online