[tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
--------------------------------------------+------------------------------
 Reporter:  backkem                         |          Owner:  cohosh
     Type:  enhancement                     |         Status:  accepted
 Priority:  Medium                          |      Milestone:
Component:  Circumvention/Snowflake         |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:                                  |         Points:  5
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor28-must
--------------------------------------------+------------------------------

Comment (by cohosh):

 Okay, I have a PR under submission for pion/webrtc:
 https://github.com/pion/webrtc/pull/816

 As mentioned in
 https://github.com/pion/webrtc/pull/763/#issuecomment-528224065, it's
 worth it for us to revisit the problems we were having in comment:28 that
 caused us to use the trickle ICE gathering method.

 I still think this library is the way to go since it seems our best path
 forward in getting Snowflake building on Windows (and probably Android as
 well). However, we've already seen in the short time we've been working
 with it that a minor version upgrade required several days of development
 time on our end to get things working again. I pointed out a concern I
 have with how this specific change was made in my comment on the PR that
 merged it: https://github.com/pion/webrtc/pull/763/#issuecomment-528967735
 The commit that broke things for us significantly altered the
 functionality of the core WebRTC API, and was made only for the purpose of
 getting an unusually constructed example working. This development
 practice isn't what I'd prefer in a library we rely on so heavily.

 Like I said, I still like this path forward, I think it will be far easier
 to maintain than libwebrtc and has many other advantages. The development
 team at pion have been very enthusiastic and helpful in addressing our
 issues and merging fixes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28942#comment:61>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online