[tor-bugs] #31598 [Applications/Tor Browser]: Properly enable letterboxing (again)

[Tor Bug Tracker & Wiki]

#31598: Properly enable letterboxing (again)
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0       |  Actual Points:
  -must-alpha                                    |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha =>
     TorBrowserTeam201909R, tbb-9.0-must-alpha
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:7 acat]:
 > Mmm, actually I thought about that, but not sure how I tested that I
 thought letterboxing was not being enabled instantly, just on a new
 window.
 >
 > In any case, here is a revised patch:
 https://github.com/acatarineu/torbutton/commit/31598+2. Now the resize
 listener is always enabled and checking the pref when it's called. Being
 strict, this still has the issue that a user with the window already
 maximized changing letterboxing pref will not get any notification, since
 these are only shown on window resize right now. Do you think we should
 also handle those cases?

 No, I think what we have now is fine. I merged your patches to `torbutton`
 (commit 1edfec57049a76052fda8eb17b6e3b8f281e3361) and `tor-browser`
 (commit f19b6946fcccb42b3b060c5ecf53ba8ec524b420), thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31598#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online