[tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

[Tor Bug Tracker & Wiki]

#31571: Add the tor version and a newline to raw_assert()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should, android,    |  Actual Points:  0.1
  macos, 035-backport, 040-backport,             |
  041-backport                                   |
Parent ID:  #31570                               |         Points:  0.1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:8 nickm]:
 > The return-value checking looks okay to me.
 >
 > I don't see any additional refactoring or comment changes on the master
 branch, however.  Did they get eaten by a force-push?  If you still want
 to do them, please put this back in needs_review when you're done.
 Otherwise this branch can go into merge_ready.

 I split the comment changes into #31612, they were unrelated to this PR.
 The refactoring wasn't possible due to layering issues with strlcpy().
 So I just checked the return values in the 0.3.5 branch instead.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31571#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online