[tor-bugs] #31598 [Applications/Tor Browser]: Properly enable letterboxing (again)

[Tor Bug Tracker & Wiki]

#31598: Properly enable letterboxing (again)
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha                                          |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Hm, so this leaves is in a weird situation, kind of: disabling/enabling
 letterboxing happens instantly. However, showing/not showing the
 notification box depends on the window creation state, which gives
 surprising results. You'd e.g. get the notification bar if you just
 enabled letterboxing but you started without it being on and vice versa. I
 think we should find a better way binding letterboxing to the notification
 bar.

 If that's to tricky I am fine just disabling that part entirely. However,
 in that case we could just rip the resizelistener etc. out.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31598#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online