[tor-bugs] #23024 [Applications/Tor Browser]: Flags to increase hardening on Windows

[Tor Bug Tracker & Wiki]

#23024: Flags to increase hardening on Windows
-------------------------------------------+-------------------------------
 Reporter:  arthuredelstein                |          Owner:  tbb-team
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  TorBrowserTeam201711, tbb-rbm  |  Actual Points:
Parent ID:  #21448                         |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by tom):

 Werror=format-security - enabled on non-Windows,
 https://bugzilla.mozilla.org/show_bug.cgi?id=1578619

 _FORTIFY_SOURCE - enabled but mingw-clang doesn't support it (yet. it's a
 WIP)

 -fno-delete-null-pointer-checks
 https://bugzilla.mozilla.org/show_bug.cgi?id=1578617

 -Wl,--enable-reloc-section - AFAICT unneeded for mingw-clang, since ASLR
 is working

 --image-base - AFAICT not needed on modern systems

 large-address-aware - enabled for mingw-clang

 --forceinteg - not applicablt to clang/lld

 --no-seh - set by lld automatically https://reviews.llvm.org/D41252 (but
 this would be good to confirm manually

 --tsaware - I'm not sure but I really hope that this is completely
 unneeded by now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23024#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online