[tor-bugs] #27604 [Applications/Tor Browser]: Relocating the Tor Browser directory is broken with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27604: Relocating the Tor Browser directory is broken with Tor Browser 8
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:  3
  tbb-8.0.1-can, TorBrowserTeam201910R           |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Thorin):

 Replying to [comment:33 acat]:
 > 4. **Rename** `tor-browser_{locale}` to something else.
 >
 > Can you confirm whether you still cannot reproduce with these steps?

 I wasn't thinking in my re-test, it helps to **not** leave the original
 dir lying around **:facepalm:** - on Windows with `9.0` (and I did not
 delete any files)

 First run after dir rename
 - the extension icons are gone in customize and about:addons
 - console errors eg `Error while loading
 'jar:file:///D:/TBTest/TB1/Browser/TorBrowser/Data/Browser/profile.default/extensions/...`
 - `torcc` file shows the original path `TB1`, not the new path `TB2`

 Second (and subsequent) run after dir rename:
 - NoScript seems fine: no console errors, icons present, test with safest
 setting did not execute JS
 - **HTTPS-E is not**: same console error, missing icon in customize and
 about:addons
 - `torcc` file updated to new path `TB2`

 see below the first line is looking for `TB1`, but `TB2`
 {{{
 Error while loading
 'jar:file:///D:/TBTest/TB1/Browser/TorBrowser/Data/Browser/profile.default/extensions
 /https-everywhere-eff at eff.org.xpi!/manifest.json'
 (NS_ERROR_FILE_NOT_FOUND) Extension.jsm:513
     readJSON resource://gre/modules/Extension.jsm:513
     onStopRequest resource://gre/modules/NetUtil.jsm:128
     _openNetworkSettings
 jar:file:///D:/TBTest/TB2/Browser/browser/omni.ja!/chrome/torlauncher/components
 /tl-process.js:751
     _controlTor
 jar:file:///D:/TBTest/TB2/Browser/browser/omni.ja!/chrome/torlauncher/components
 /tl-process.js:586
     TorStartAndControlTor
 jar:file:///D:/TBTest/TB2/Browser/browser/omni.ja!/chrome/torlauncher/components
 /tl-process.js:333
     observe
 jar:file:///D:/TBTest/TB2/Browser/browser/omni.ja!/chrome/torlauncher/components
 /tl-process.js:135
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27604#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online