[tor-bugs] #32131 [Circumvention/Snowflake]: `SetDeadline not implemented` errors in proxy-go output
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Oct 25 21:14:43 UTC 2019
#32131: `SetDeadline not implemented` errors in proxy-go output
-------------------------------------+-----------------------------
Reporter: dcf | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+-----------------------------
Comment (by cohosh):
Replying to [comment:6 dcf]:
> Replying to [comment:4 cohosh]:
> > Hmm, actually I just realized the deadline still could serve a purpose
for the websocket connection to the bridge.
> I haven't come across an actual timeout in this sense... the bridge
usually closes the websocket connection directly when the OR connection
closes or times out. Do you know whether this code would ever be needed?
I have never seen it used. I think we're okay to remove it.
> I agree the timeout is probably unnecessary on the WebSocket connection.
We don't usually do that timeout thing in our other copy loops. Like
arlolra says, `CopyLoopTimeout` should then become just `CopyLoop` or
`copyLoop`.
Thanks! Updated patch: 0001-Remove-now-unecessary-timeoutConn.patch
(ignore the *.2.patch file)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32131#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list