[tor-bugs] #32191 [Core Tor/Tor]: when cross-compiling, lzma and zstd will be detected on build system

[Tor Bug Tracker & Wiki]

#32191: when cross-compiling, lzma and zstd will be detected on build system
----------------------------------+------------------------------------
 Reporter:  eighthave             |          Owner:  (none)
     Type:  defect                |         Status:  needs_revision
 Priority:  Medium                |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  Android 042-backport  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by teor):

 Sounds good.

 Let's think carefully about how to avoid breaking existing build setups.

 Here's one possible design:
 1. If prefix is set, and PKG_CONFIG_PATH is not set, use prefix to derive
 a value for PKG_CONFIG_PATH
 That should minimise breakage.

 Normally, we'd add the new path to the front of the list of paths, but
 that could cause subtle bugs. (Like enabling the wrong lzma.)

 I also wonder if Windows and some other cross-compiles want to use
 PKG_CONFIG_SYSROOT_DIR instead. We'll need to check what Tor Browser is
 doing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32191#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online