[tor-bugs] #32195 [Core Tor/Tor]: Rename net_is_disabled, net_is_completely_disabled, and PERIODIC_EVENT_FLAG_NEED_NET

[Tor Bug Tracker & Wiki]

#32195: Rename net_is_disabled, net_is_completely_disabled, and
PERIODIC_EVENT_FLAG_NEED_NET
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  technical-debt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 The net_is_disabled() function returns true when we are in soft
 hibernation, which can be confusing, and which is probably a partial cause
 of #32108.  Similarly, PERIODIC_EVENT_FLAG_NEED_NET prevents a callback
 from running when we are in soft hibernation, which is also potentially
 confusing.

 Let's figure out good names for these functions and flags, and audit their
 usage to make sure that there are no more bugs kicking around.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32195>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online