[tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Oct 21 21:24:20 UTC 2019
#31882: move Android build config into core tor
---------------------------------+------------------------------------
Reporter: eighthave | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: Android, tbb-mobile | Actual Points:
Parent ID: | Points:
Reviewer: nickm | Sponsor:
---------------------------------+------------------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
I've had a look over the changes, except for the gitlab CI stuff which I'm
not competent to evaluate. Since others asked for that, maybe they could
weigh in whether it seems right to them? (I was about to suggest doing
gitlab CI in a separate branch, but I see that somebody else requested it,
so I probably should defer to them.)
I've left some comments on the PR. Additionally, this needs a file in the
changes/* directory to explain what it is when we generate the changelog.
The doc/HACKING/CodingStandards.md file explains how those look.
Please let me know if you have any questions. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31882#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list