[tor-bugs] #31144 [Applications/Tor Browser]: ESR68 Network Code Review

[Tor Bug Tracker & Wiki]

#31144: ESR68 Network Code Review
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201910R, tbb-9.0       |  Actual Points:
  -must-alpha, tbb-proxy-bypass                  |
Parent ID:                                       |         Points:  10
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:23 sysrqb]:
 > >> CustomTabsActivity.java - Several methods emit potentially external
 Intents
 > > My only concern here is onLoadRequest() when the scheme isn't handled
 by the browser. That's the only place where the user wasn't prompted. I
 don't know how the customtabs UI should handle this situation. We can
 break this functionality for now, until we find how this should be done
 correctly.
 >
 > This is included in the patch for #26529, but in this case we don't
 prompt. #26529 seemed like the better commit, but I can move this into its
 own commit.

 I pushed `bug31144_05` with only this patch on top of `68.1.0esr-9.0-3`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31144#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online