[tor-bugs] #31810 [Core Tor]: Bug: ../src/lib/process/process_unix.c:265: process_unix_exec: Assertion line should be unreached failed; aborting.

[Tor Bug Tracker & Wiki]

#31810: Bug: ../src/lib/process/process_unix.c:265: process_unix_exec: Assertion
line should be unreached failed; aborting.
--------------------------------------+------------------------------------
 Reporter:  Parckwart                 |          Owner:  ahf
     Type:  defect                    |         Status:  needs_revision
 Priority:  Very High                 |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor                  |        Version:  Tor: 0.4.1.5
 Severity:  Normal                    |     Resolution:
 Keywords:  042-must, 041-regression  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------

Comment (by ahf):

 1) I have added a test case to test for how we handle process termination
 in general. During this I discovered that we had an API difference where
 on Windows the exit callback of a given process_t would NOT be called when
 CreateProcessA() failed (with for example the  no such file or directory
 error).

 2) I have based the patches on maint-0.4.0 now, but also created a PR for
 0.4.2 and master with an added practracker exception.

 0.4.0, 0.4.1 PR: https://github.com/torproject/tor/pull/1424
 0.4.2, master PR: https://github.com/torproject/tor/pull/1426

 Let's see what CI says to both of them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31810#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online