[tor-bugs] #32103 [Core Tor/Tor]: Subsystem "thread_cleanup" is never called
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Oct 17 03:25:54 UTC 2019
#32103: Subsystem "thread_cleanup" is never called
--------------------------+------------------------------------
Reporter: opara | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-should | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by opara):
I made a [https://github.com/torproject/tor/pull/1418 PR on Github] with
some changes that should fix this problem. Feel free to use them if
they're helpful.
> This fixes ticket #32103. It extends the threadpool to allow a
customizable thread spawn function. This allows us to use our own spawn
function which calls subsystems_thread_cleanup and a new
subsystems_thread_init. It also calls 'spawn_exit', which negates the need
for [https://github.com/torproject/tor/pull/1412 1412]. Finally the above
two functions are called in the main thread after subsystems_init and
before subsystems_shutdown respectively.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32103#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list