[tor-bugs] #31286 [Applications/Tor Browser]: Include bridge configuration into about:preferences
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Oct 16 12:09:56 UTC 2019
#31286: Include bridge configuration into about:preferences
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| pospeselr
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-9.0-must-alpha, ff68-esr, ux- | Actual Points:
team, TorBrowserTeam201910 |
Parent ID: #10760 | Points: 15
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-9.0-must-alpha, ff68-esr, ux-team, TorBrowserTeam201910R
=> tbb-9.0-must-alpha, ff68-esr, ux-team, TorBrowserTeam201910
* status: needs_review => needs_revision
Comment:
Replying to [comment:40 pospeselr]:
> tor-launcher (rebased on latest):
https://gitweb.torproject.org/user/richard/tor-
launcher.git/commit/?h=bug_31286_review2&id=5f40953122f759fe6a4992f7a61e4cb3d5888d53
Thanks, I picked that up in commit
017ca3ee046af4b1afa641f772834d373ff750c7.
However, it seems we essentially have duplicated strings now, right? One
version in the .properties file and one in the .dtd one. Any reason you
did not use the technique Alex used in #24653 to avoid adding duplicated
strings?
> tor-browser fixup: https://gitweb.torproject.org/user/richard/tor-
browser.git/commit/?h=bug_31286_review4
I am fine with the decision to omit the link for now, however, could you
make that a) a fixup commit to your previous one and b) open a new ticket
to get the correct fix done (that is (i) having actually a link working
and (b) removing your hiding the link)?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list