[tor-bugs] #31561 [Core Tor/Tor]: hs-v3: Service can keep unused intro points in its list

[Tor Bug Tracker & Wiki]

#31561: hs-v3: Service can keep unused intro points in its list
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:  dgoulet
     Type:  defect                     |         Status:  needs_review
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.4.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-hs, hv-v3, 042-should  |  Actual Points:  0.1
Parent ID:  #30200                     |         Points:  0.2
 Reviewer:  asn, mikeperry             |        Sponsor:  Sponsor27-must
---------------------------------------+-----------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review
 * reviewer:  asn => asn, mikeperry


Comment:

 Thanks Mike!!!

 I'm passing this review on to you since asn is away and you have a good
 grasp on this problem.

 I basically removed the `HS_VANGUARD` purpose from the new functions and
 put it back in the `is_hidden_service()` like it is today.

 New PR with branch rebased/squashed on latest 042:
 https://github.com/torproject/tor/pull/1411

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31561#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online