[tor-bugs] #31144 [Applications/Tor Browser]: ESR68 Network Code Review

[Tor Bug Tracker & Wiki]

#31144: ESR68 Network Code Review
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201910, tbb-9.0        |  Actual Points:
  -alpha-must                                    |
Parent ID:                                       |         Points:  10
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by tom):

 Replying to [comment:7 mikeperry]:
 > 4. For Rust, I found sendmsg and recvmsg only in mio and audioipc. I
 think this is fine? (I am asking about those two because Ritter's tool
 whitelisted them and I wanna double check).

 That matches my finding from
 https://bugzilla.mozilla.org/show_bug.cgi?id=1376621#c23

 > 5. Otherwise has Ritter's network symbol tool been run on FF68ESR for
 Rust?

 It runs on all builds in both esr68 and central; however in central
 several critical functions got allowlisted so it's not very effective
 anymore.

 And when I say 'runs on all builds' I mean if Tor added a rust patch that
 used a networking function, this check would break the (firefox) build
 (during that step of the tor browser build process).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31144#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online