[tor-bugs] #30504 [Applications/Tor Browser]: Investigate if New Identity works properly after moving to ESR 68

[Tor Bug Tracker & Wiki]

#30504: Investigate if New Identity works properly after moving to ESR 68
-------------------------------------------------+-------------------------
 Reporter:  acat                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-newnym, tbb-9.0-must-  |  Actual Points:  1.5
  alpha, TorBrowserTeam201910R                   |
Parent ID:                                       |         Points:  0.25
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by acat):

 Fixup for switching back to idb storage for webext:
 https://github.com/acatarineut/tor-browser/commit/30504.

 I think it's not possible to do a fixup/squash and modify the original
 commit message, right? Because the preferences commit message includes
 #31396 and ideally we would want to remove that.

 Besides, this fixup is a bit tricky, since we would also want to revert
 all the `extensions.webextensions.ExtensionStorageIDB.migrated` pref
 branch so that the idb storage migration is performed again for all
 extensions. This is because it might be possible that this migration was
 done, then "destroyed" by the previous `Services.qms.clear()` and
 switching this back leads to a bad state.

 So perhaps it's better to open a new ticket for this and do it later...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30504#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online