[tor-bugs] #30344 [Core Tor/Tor]: conn_read_callback is called on connections that are marked for closed

[Tor Bug Tracker & Wiki]

#30344: conn_read_callback is called on connections that are marked for closed
-------------------------------------------------+-------------------------
 Reporter:  robgjansen                           |          Owner:  asn
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.8
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-conn, 035-backport,              |  Actual Points:
  041-deferred-20190530, 042-should              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by pastly):

 * status:  needs_information => needs_review


Comment:

 asn's branch fixes the issue.

 Two experiments:

 1. asn's branch at 0efa7827e476f63c442ac0536aa874458449ef78. ~300 relay
 Shadow network with appropriate client load.

 2. same, but with at de66bed604377db23cfa303b83e385ef59121a64 (the commit
 just before asn's fix).

 The first has been running for 48 of 60 simulation minutes and is still
 going strong. The second hit the infinite loop just 6 simulated minutes in
 and has died as a result of a shadow buffer overflowing from this infinite
 loop in Tor. Hitting the infinite loop 5 or 6 minutes in to the experiment
 is consistent with what I've been seeing. (The clients start generating
 traffic at the 5 minute mark)

 Changing ticket to (''rolls dice'') needs_review

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30344#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online