[tor-bugs] #31941 [Metrics/Onionoo]: Old reverse DNS lookups are sometimes not cleared properly

[Tor Bug Tracker & Wiki]

#31941: Old reverse DNS lookups are sometimes not cleared properly
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 irl, please review
 [https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-31941&id=4693bba81b8aacccbeb93489a841ea97a445d962
 commit 4693bba in my task-31941 branch].

 I tested this patch on a local Onionoo instance that was based on a backup
 from omeiense. Here's how the details status file of t6kexit1 changed:

 {{{
 @@ -99,7 +99,7 @@
    "nickname": "t6kexit1",
    "address": "70.39.93.111",
    "first_seen_millis": 1568728800000,
 -  "last_seen_millis": 1570100400000,
 +  "last_seen_millis": 1570086000000,
    "or_port": 443,
    "dir_port": 80,
    "relay_flags": [
 @@ -117,10 +117,10 @@
    "exit_addresses": {
      "185.229.59.167": 1570043529000
    },
 -  "consensus_weight_fraction": 2.0087525e-07,
 +  "consensus_weight_fraction": 1.9711189e-07,
    "guard_probability": 0,
    "middle_probability": 0,
 -  "exit_probability": 9.059996e-07,
 +  "exit_probability": 8.4231533e-07,
    "latitude": 36.0907,
    "longitude": -115.0886,
    "country_code": "us",
 @@ -129,9 +129,6 @@
    "city_name": "Las Vegas",
    "as_name": "Sharktech",
    "as_number": "AS46844",
 -  "verified_host_names": [
 -    "c-73-95-69-17.hsd1.co.comcast.net"
 -  ],
    "version": "0.4.1.5",
    "version_status": "recommended"
  }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31941#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online