[tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Oct 4 01:53:16 UTC 2019


#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  task          |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  042-can       |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I left some comments on the ticket:
 * document tor-coccinelle.h
 * document test_operator_cleanup
 * make try_parse.sh exit with a non-zero status if it finds any files
 * make (a mode for) try_parse.sh that shows the parsing errors, so they
 can be fixed
 * it looks like you missed some files:
 {{{
 $ find src/{app,config,core,feature,lib,test,tools,win32} -name *.c -o
 -name *.h | xargs ~/dev/tor/scripts/coccinelle/try_parse.sh
 # 143 files
 }}}

 Reminder: please fill in actual points on this ticket.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31705#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list