[tor-bugs] #31286 [Applications/Tor Browser]: Include bridge configuration into about:preferences
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Oct 1 20:47:47 UTC 2019
#31286: Include bridge configuration into about:preferences
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| pospeselr
Type: task | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-9.0-must-alpha, ff68-esr, ux- | Actual Points:
team, TorBrowserTeam201910R |
Parent ID: #10760 | Points: 15
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Comment (by acat):
While I finish a first pass + testing: I think it would be good for new
code to follow mozilla style rules. Especially since now it's quite easy
to automatically fix these: `./mach lint -l eslint --fix
browser/components/tornetworksettings browser/components/torstrings` (fix
in #31914 is needed).
There are still a few remaining errors that have to be fixed manually, but
I think this should not be very difficult. Many should be solved with `/*
import-globals-from [...].js */`, I think. Or trivial changes like
`ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm"); -> const {
XPCOMUtils } =
ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");`. Or adding a
missing import.
Unless there are some concerns, I plan to review the result of running the
above style-fixing command but without fixing manual errors (this is the
result for me: https://github.com/acatarineu/tor-
browser/commits/bug_31286_review_eslint).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list