[tor-bugs] #31929 [Applications/Tor Browser]: &vendorShortName; is escaped in ar breaking the referencing of this entity

[Tor Bug Tracker & Wiki]

#31929: &vendorShortName; is escaped in ar breaking the referencing of this entity
------------------------------------------------+--------------------------
 Reporter:  gk                                  |          Owner:  tbb-team
     Type:  defect                              |         Status:  closed
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:  fixed
 Keywords:  TorBrowserTeam201910, tbb-branding  |  Actual Points:  0.1
Parent ID:                                      |         Points:  0.1
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Description changed by gk:

Old description:

> We have `<!ENTITY project.tpoLink         "&vendorShortName؛">` in
> `ar`'s `aboutDialog.dtd`. Note for comparision, just one line above in
> that file `<!ENTITY project.start           "طوّر &brandShortName;">`.
>
> The latter is correct as the `&` and `;` are making sure `brandShortName`
> as it is translated elsewhere gets included. But that fails if one starts
> to escape those characters (e.g. by replacing `&` with `&amp`).
>
> Thanks to Thorin for reporting this issue.

New description:

 We have `<!ENTITY project.tpoLink         "&vendorShortName؛">` in
 `ar`'s `aboutDialog.dtd`. Note for comparison, just one line above in that
 file `<!ENTITY project.start           "طوّر &brandShortName;">`.

 The latter is correct as the `&` and `;` are making sure `brandShortName`
 as it is translated elsewhere gets included. But that fails if one starts
 to escape those characters (e.g. by replacing `&` with `&amp`).

 Thanks to Thorin for reporting this issue.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31929#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online