[tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--------------------------------------+---------------------------
 Reporter:  boklm                     |          Owner:  pospeselr
     Type:  defect                    |         Status:  closed
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:  fixed
 Keywords:  TorBrowserTeam201911R     |  Actual Points:  0.5
Parent ID:                            |         Points:  0.5
 Reviewer:                            |        Sponsor:
--------------------------------------+---------------------------
Changes (by gk):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 pospeselr]:
 > gk: I speculated in IRC that you might have a startupCache issue:

 Actually, I don't think so see 1) in comment:3.

 [snip]

 > https://people.torproject.org/~richard/builds/bug_32508/tor-browser-
 linux64-tbb-nightly_en-US.tar.xz

 Thanks! I think the mistake I made was just patching `torPane.xul` (that
 is 5) in comment:3 is not enough). It seems when building then
 corresponding changes in `preferences.xul` got made which I overlooked by
 trying to take a shortcut.

 We are good here, thanks! Cherry-picked your patch to `tor-
 browser-68.2.0esr-9.5-1` (commit
 e847b87fda117ebf06459755b5dbd037eb1d349a).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32508#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online