[tor-bugs] #32427 [Core Tor/Tor]: Refactor options_act_reversible into manageable chunks

[Tor Bug Tracker & Wiki]

#32427: Refactor options_act_reversible into manageable chunks
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .3
Parent ID:  #32408        |         Points:
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 Okay, here's the status: I have tests for the log and directory code, but
 I wasn't able to figure out testing for the listener code: that is very
 hairy in tor.

 I've hit a bug in the branch when I rebased: it looks like we are logging
 less than we were before, and some of the new test_parseconf log tests are
 complaining. I'll try to look at them tonight or tomorrow.

 Teor, can you have a look at the new tests and see if you're okay without
 full testing on listeners?  My next steps here are to get the current
 tests passing again, do some function renaming, and then needs_review
 again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32427#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online