[tor-bugs] #31823 [Core Tor/Stem]: HSv3 descriptor support in stem [encoding]
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Nov 13 09:12:47 UTC 2019
#31823: HSv3 descriptor support in stem [encoding]
-------------------------------------------------+-------------------------
Reporter: asn | Owner: atagar
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution:
Keywords: tor-hs scaling onionbalance | Actual Points: 2
network-team-roadmap-september tor-spec |
Parent ID: #26768 | Points: 5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by asn):
Hello Damian,
I'm back for good now. I see you are still working on the hsv3 branch so
I'm not gonna bother you on that. I'm also waiting for you to finish
before I jump in and review. In the meanwhile, I will be working on the
core onionbalance code.
I see you've been changing a big part of the code. For me, the most
important part is not to change the interface of the
`test_encode_decode_descriptor()` unittest, since I'm gonna be using a
similar interface in onionbalance.
So far you haven't done any major changes in the test, however you are
using the same keys for all introduction points:
{{{
intro_points = [
IntroductionPointV3.create('1.1.1.1', 9001, expiration, onion_key,
enc_key, auth_key, signing_key),
IntroductionPointV3.create('2.2.2.2', 9001, expiration, onion_key,
enc_key, auth_key, signing_key),
IntroductionPointV3.create('3.3.3.3', 9001, expiration, onion_key,
enc_key, auth_key, signing_key),
]
}}}
For the test to be proper, each introduction point should have unique keys
which is what the old `_helper_get_intro()` function was doing.
Other than that, looks good to me! Keep on doing it! Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31823#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list