[tor-bugs] #32427 [Core Tor/Tor]: Refactor options_act_reversible into manageable chunks
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Nov 11 20:50:05 UTC 2019
#32427: Refactor options_act_reversible into manageable chunks
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: .3
Parent ID: #32408 | Points:
Reviewer: teor | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Comment (by nickm):
Teor's comment was:
> The design looks good.
>
> How about naming things by what they *are*:
> * options_act_pre_port()
> * options_act_port()
> * options_act_pre_log()
> * options_act_log()
> * options_act...()
>
> And then if someone wants to know the order, they can read the comments
or the code?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32427#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list