[tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Nov 7 22:12:55 UTC 2019
#31130: Use Debian 10 for our Android container images
-------------------------------------------+-------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201911 | Actual Points:
Parent ID: #31127 | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------+-------------------------------
Changes (by boklm):
* status: needs_review => needs_revision
* keywords: tbb-rbm, TorBrowserTeam201911R => tbb-rbm,
TorBrowserTeam201911
Comment:
Replying to [comment:35 sisbell]:
>
> Fixed
> * added correct apksigner path for debian
> * removed use of install_jdk flag (override pre_pkginst)
>
> https://github.com/sisbell/tor-browser-
build/commit/da928c8cc046ad71e718ddd1eb2c4690af8097dd
in `var/pre_pkginst`:
{{{
sha256sum
04f35746d85ea065a06a79a0ffb95825bd591a1b3a0f7cc641d06e7d263bbef5
openjdk-8-jdk_$JDK_VERSION.deb | sha256sum -c
sha256sum
92b4f8fb77d793a86e0b03b3b0750592b40a26a5d75956d10dd984a7b3aad4c9 openjdk-8
-jdk-headless_$JDK_VERSION.deb | sha256sum -c
sha256sum
84bf52b6cce20ead08b0d5b9fd9b81b4aa3da385ca951b313fe11d5cb1aa4d17 openjdk-8
-jre-headless_$JDK_VERSION.deb | sha256sum -c
sha256sum
75057205b56791edbc4dd0358cb56efd7d20ce0cb730d6ecba38e37267d72b9b
openjdk-8-jre_$JDK_VERSION.deb | sha256sum -c
}}}
This is wrong, we could replace the checksum in those lines by anything,
and it will never fail. Running `sha245sum checksum some-file | sha256sum
-c` will complain that the file `checksum` does not exist, but it is
basically equivalent to running `sha245sum some-file | sha256sum -c` which
is equivalent to doing nothing.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31130#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list