[tor-bugs] #32385 [Core Tor/Tor]: doxygen: respect --enable-fatal-warnings
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Nov 7 19:22:21 UTC 2019
#32385: doxygen: respect --enable-fatal-warnings
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: doxygen | Actual Points:
Parent ID: | Points: 0
Reviewer: catalyst | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by catalyst):
* status: needs_review => merge_ready
Comment:
Replying to [comment:7 nickm]:
> Replying to [comment:6 nickm]:
> > I've made and pushed the other change. Thanks for the review!
>
> (which is to say: I've done a fix for the documentation issue and pushed
it to the branch here pending your approval.)
Thanks! I commented on the pull request about a minor wording issue/typo.
Feel free to merge after fixing.
Note: also, as far as I can tell, none of our CI runs `make doxygen`
(yet?). So we might want to start doing that in CI when we have everything
fully documented from Doxygen's perspective.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32385#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list