[tor-bugs] #32191 [Core Tor/Tor]: when cross-compiling, lzma and zstd will be detected on build system
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Nov 6 00:11:15 UTC 2019
#32191: when cross-compiling, lzma and zstd will be detected on build system
-----------------------------------+------------------------------------
Reporter: eighthave | Owner: teor
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: Android, 042-backport | Actual Points:
Parent ID: | Points:
Reviewer: nickm | Sponsor:
-----------------------------------+------------------------------------
Changes (by teor):
* status: assigned => needs_review
Comment:
Replying to [comment:30 nickm]:
> >Nick, do you think we should backport this build fix to 0.4.2?
>
> Hm. Can we envision this breaking any reasonable build that would
previously have succeeded? If not, I think a backport is reasonable.
It only sets PKG_CONFIG_PATH when it's unset. So it does override the
default path compiled in to the pkg-config binary, but that path is wrong
for cross-compiles. It never overrides user-configured paths.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32191#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list