[tor-bugs] #30867 [Circumvention/Snowflake]: Write proxy-go tests to cover existing implementation

[Tor Bug Tracker & Wiki]

#30867: Write proxy-go tests to cover existing implementation
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  cohosh
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tests, anti-censorship-roadmap-      |  Actual Points:
  september                                      |
Parent ID:  #29259                               |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor28
-------------------------------------------------+-------------------------
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 Here's some work for improving proxy-go test coverage:
 https://github.com/cohosh/snowflake/compare/bug29207...ticket30867

 I modified the proxy-go code a bit in
 [https://github.com/cohosh/snowflake/commit/3c53e082f40005bdf0cfac0d5013224317443bdf
 this commit] to use an http.RoundTripper as discussed above.

 The test coverage is now at 37.2% (up from 2.2%). I don't think the rest
 of the code makes sense to write tests for in its current form since that
 would require some larger refactors.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30867#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online