[tor-bugs] #32360 [Applications/Tor Browser]: Rethink fix for #31564

[Tor Bug Tracker & Wiki]

#32360: Rethink fix for #31564
------------------------------------------+--------------------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam201911
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 In #31564 we added a step in the building process for Android where the
 apk is unzipped and then rezipped. This provided an easy way for
 normalizing the ordering of files in the archive.

 Unfortunately, rezipping all files results in files being compressed
 differently. #32342 is an unfortunate side-effect of this, where `omni.ja`
 was compressed a second time when it was added into the apk. That ticket
 shows significant changes between how files were added in the original apk
 verses how they are added in the rezipped apk. We don't know if there are
 more/different bugs lurking now.

 We should look closer at how Mozilla [https://searchfox.org/mozilla-
 esr68/source/python/mozbuild/mozbuild/action/package_fennec_apk.py#68
 modify the apk]. They have a custom [https://searchfox.org/mozilla-
 esr68/source/python/mozbuild/mozpack/copier.py#506 jar thing].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32360>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online