[tor-bugs] #25713 [Core Tor/Tor]: "DisableNetwork is set" log message in Tor Browser scares/confuses users

[Tor Bug Tracker & Wiki]

#25713: "DisableNetwork is set" log message in Tor Browser scares/confuses users
--------------------------------------------+------------------------------
 Reporter:  arma                            |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  unspecified
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ux-team, 040-deferred-20190220  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor19
--------------------------------------------+------------------------------

Comment (by catalyst):

 Suggestion: remember the source of the `DisableNetwork=1`, e.g., command
 line, config file or controller connection, so we can log something like
 "command line set DisableNetwork" or "controller set DisableNetwork".
 Maybe even have an additional parameter to DisableNetwork so an
 application can put a user-friendly reason, e.g., "Tor Browser startup"
 (tor command line `DisableNetwork 0` when Tor Browser starts up) or "Tor
 Browser config dialog".

 Also, log a message when we set `DisableNetwork=0`. Right now a user has
 no way to tell from the log files that we turned DisableNetwork off.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25713#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online