[tor-bugs] #29670 [Core Tor/Tor]: Could not create SOCKS args string

[Tor Bug Tracker & Wiki]

#29670: Could not create SOCKS args string
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport, 040-backport, ux,      |  Actual Points:
  regression?, 041-should, 041-regression?       |
Parent ID:                                       |         Points:  .5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor19
-------------------------------------------------+-------------------------
Changes (by nickm):

 * sponsor:   => Sponsor19


Comment:

 Looks like the bug here is in get_proxy_type():
 {{{
   if (options->ClientTransportPlugin)
     return PROXY_PLUGGABLE;
   else if (options->HTTPSProxy)
     return PROXY_CONNECT;
   else if (options->Socks4Proxy)
     return PROXY_SOCKS4;
   else if (options->Socks5Proxy)
     return PROXY_SOCKS5;
   else
     return PROXY_NONE;
 }}}

 The offending commit looks like 41d2b4d3af01b34beb2951028cdbc45b5f41e08e
 in 0.2.6.1-alpha.

 It looks like this will only happen when you have ClientTransportPlugin
 enabled, ''and'' you have a socks5 proxy set, ''and'' you aren't using a
 bridge, ''and'' your proxy asks for authentication.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29670#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online