[tor-bugs] #30560 [Applications/Tor Browser]: Onboarding toolbar graphic doesn't match actual toolbar after upgrade

[Tor Bug Tracker & Wiki]

#30560: Onboarding toolbar graphic doesn't match actual toolbar after upgrade
--------------------------------------------+--------------------------
 Reporter:  sysrqb                          |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-onboarding, tbb-8.5-issues  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------
Changes (by gk):

 * keywords:   => tbb-onboarding, tbb-8.5-issues
 * cc: mcs, brade (added)


Comment:

 Replying to [comment:2 sysrqb]:
 > yes, that is understandable - so the new toolbar layout is only used in
 new installations because we don't want to modify any customizations. I'm
 more concerned about the onboarding graphic not matching the real toolbar.
 I don't know how that should be corrected. Maybe deleting the hamburger
 icon will help? After I looked at that graphic, then I looked up at the
 hamburger icon and expected to see the onion and shield icons there - but
 they weren't there. They were on the other side of the search box. I found
 this confusing.

 Yes, it is. The logic says the icons get inserted after the URL bar. So,
 given we have only one image showing the new icons during the onboarding,
 what we did was taking a vanilla Tor Browser 8 as we ship it and go from
 that one. That might get confusing for users who customized their toolbar
 and added the search box, yes. It might even be confusing for users that
 still have an old Tor Browser that originally shipped with the search bar
 and just used the internal updater every time until 8.5 now. Still, I am
 not sure how we can know what the user's toolbar layout looks like and
 show the respective image. Or maybe, on second thought, the onboarding
 logic could actually figure that out and show the proper image out of,
 say, three scenarios we would take care of? But then again, that's quite
 some work to do. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30560#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online