[tor-bugs] #28655 [Circumvention/BridgeDB]: If a bridge supports obfs4, don't give out its other flavors

[Tor Bug Tracker & Wiki]

#28655: If a bridge supports obfs4, don't give out its other flavors
------------------------------------+------------------------------
 Reporter:  arma                    |          Owner:  phw
     Type:  defect                  |         Status:  needs_review
 Priority:  High                    |      Milestone:
Component:  Circumvention/BridgeDB  |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  bridgedb                |  Actual Points:
Parent ID:                          |         Points:  2
 Reviewer:                          |        Sponsor:  Sponsor19
------------------------------------+------------------------------
Changes (by phw):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:17 sysrqb]:
 > -
 [https://gitweb.torproject.org/user/phw/bridgedb.git/tree/bridgedb/test/test_https_distributor.py?h=bug28655&id=ad034c358a38dcea98948d4b2c50e0758f15ce13#n197
 Reusing]  `bridges` is a little confusing (used first as a method
 parameter), can you use a different variable name?

 Yes, good point.

 > - I agree extending `SUPPORTED_TRANSPORTS` or creating a new `list`
 config option like `PROBING_RESISTANT_TRANSPORTS` is a good idea. Hard-
 coding the list of probing resistant PTs in one place is not great, but
 hard-coding them in two places is asking for bugs :)

 I created a separate `PROBING_RESISTANT_TRANSPORTS` in bridgedb.conf,
 right under `SUPPORTED_TRANSPORTS`. I was a bit undecided if this is
 something we should expose in the BridgeDB config because it's not meant
 to be configurable unless you really know what you're doing. That said, I
 agree that a separate config options seems to be the cleanest solution.

 > For the leekspin patch, I think it looks good. My only concern is in the
 [https://gitweb.torproject.org/user/phw/leekspin.git/tree/leekspin/util.py?id=3bc9c660e8df80fe89693c8e4fad38955011bf20#n65
 description] of the new argument. It says `m` out of `n`, but it's not
 immediately obvious what `m` is here. `n` is an actual argument (`-n`,
 `--descriptors`), but `m` is not a valid argument. Replacing `<m>` with
 `<xp>` would make it more readable, or somehow note `m` **is** `xp`: "make
 `<m>` (`xp`) out of all `<n>`".

 Good point, also fixed.

 The latest commit in my branch addresses your review:
 https://gitweb.torproject.org/user/phw/bridgedb.git/log/?h=bug28655
 And here's the leekspin fix:
 https://gitweb.torproject.org/user/phw/leekspin.git/commit/?id=d34c804cd0f01af5206833e62c0dedec8565b235

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28655#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online