[tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,       |
  040-backport, postfreeze-ok, network-team-     |
  roadmap-2019-Q1Q2, 041-should                  |
Parent ID:  #28634                               |         Points:  3
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 dgoulet - So far we have not experienced any obvious reliability issues
 due to this bug while testing #26834 (which uses #28780, which changes
 client-side INTRO and REND circ purposes to PADDING circs).

 I think this means that the hs_circuitmap reliability issues do not apply
 to client-side intros?

 My guess is it is because clients only seem to use this map for the 128bit
 rend cookie, and not any permanent mappings that could be invalid later.
 In which case, this is "just" a client-side memory leak of this state with
 #28780, and not a reliability problem?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29034#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online