[tor-bugs] #30361 [Core Tor/Tor]: CID 1444908: MISSING_LOCK / CID 1444769: TAINTED_SCALAR

[Tor Bug Tracker & Wiki]

#30361: CID 1444908: MISSING_LOCK / CID 1444769: TAINTED_SCALAR
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  coverity      |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 The fix for 1444908 seems OK, but I don't think the fix for 1444769 is
 right. Changing the NUL bytes to ' ' seems like it will just yield weird
 results later iff that path is taken. We can't set the file length to the
 length of the string up until the first NUL byte/EOF?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30361#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online