[tor-bugs] #30286 [Core Tor/Tor]: pre-push git hook will warn about fixups for no reason

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 14 08:59:16 UTC 2019


#30286: pre-push git hook will warn about fixups for no reason
--------------------------------+------------------------------------
 Reporter:  asn                 |          Owner:  rl1987
     Type:  defect              |         Status:  needs_revision
 Priority:  Medium              |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor        |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  tor-ci git-scripts  |  Actual Points:
Parent ID:                      |         Points:  0.2
 Reviewer:  asn                 |        Sponsor:
--------------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Looks good, but let's document the new env var in the top-level file
 comment, so that people dont have to read the source to discover this new
 feature.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30286#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list