[tor-bugs] #30451 [Circumvention/Snowflake]: snowflake-client has executable stack

[Tor Bug Tracker & Wiki]

#30451: snowflake-client has executable stack
-------------------------------------+--------------------------
 Reporter:  boklm                    |          Owner:  cohosh
     Type:  defect                   |         Status:  assigned
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+--------------------------

Comment (by cohosh):

 Yep, it's a cgo thing.

 The solution here is to add the `noexecstack` cgo LD flag to go-webrtc:
 {{{ #cgo LDFLAGS: -L${SRCDIR}/lib -z noexecstack }}}

 However, this will currently throw an error because of golang's
 [https://github.com/golang/go/issues/23937 whitelist] on linker and
 compiler options. This can be solved by setting the environment variable
 `CGO_LDFLAGS_ALLOW` to a regex that recognizes the `-z noexecstack`
 option.

 I'll work on a patch for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30451#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online