[tor-bugs] #22210 [Core Tor/Tor]: circuit_is_acceptable is slow due to IP and fingerprint parsing

[Tor Bug Tracker & Wiki]

#22210: circuit_is_acceptable is slow due to IP and fingerprint parsing
-----------------------------------+----------------------------------
 Reporter:  teor                   |          Owner:  neel
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor           |        Version:  Tor: 0.2.8.12
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-hs, 032-unreached  |  Actual Points:
Parent ID:  #30221                 |         Points:  1
 Reviewer:                         |        Sponsor:
-----------------------------------+----------------------------------
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR is here: https://github.com/torproject/tor/pull/1004

 The only changes I have done is calling `tor_addr_parse()` only where it
 is needed as arma said in Comment 2.

 Keep in mind that AppVeyor failed, but it is not a build error as much as
 it is that AppVeyor 64-bit was unable to fetch the Git repo:

 {{{
 Build started
 git clone -q --depth=50 https://github.com/torproject/tor.git
 C:\projects\tor
 fatal: unable to access 'https://github.com/torproject/tor.git/': Failed
 to connect to github.com port 443: Timed out
 Command exited with code 128
 C:\Python27\python.exe %APPVEYOR_BUILD_FOLDER%\scripts\test\appveyor-irc-
 notify.py irc.oftc.net:6697 tor-ci failure
 C:\Python27\python.exe: can't open file 'C:\projects\tor\scripts\test
 \appveyor-irc-notify.py': [Errno 2] No such file or directory
 Command exited with code 2
 }}}

 Source:
 https://ci.appveyor.com/project/torproject/tor/builds/24367946/job/xu0uiwp0h847t6nu

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22210#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online