[tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity,            |  Actual Points:
  TorBrowserTeam201904, GeorgKoppen201904        |
Parent ID:  #24855                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Okay, I made some more notes meanwhile:
 {{{
 torbutton-extensions.xul:
 -------------------------
 due to #10280 + #15984, can go during esr68 trans, brand.dtd contains
 locale
 strings for that one

 aboutDialog.xul:
 ----------------
 modifications for about dialog, contains css in skin/aboutDialog.png; got
 included in #5698 and we have #28561 for migration

 big tasks:
 ----------
 1) setting up localization mechanisms for translating torbutton strings in
 tor-browser, maybe solve together with android strings translation

 2) getting rid of our overlays and include that code directly in the
 browser
 where it is needed (and get rid of the unnecessary things)

 questions:
 ----------
 mcs/brade: what are homePage* items in brand.properties still used for?
 double-check dxr for usage
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online